[PATCH] D152685: [clangd] Decouple IncludeCleaner implementation from Config

2023-06-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG031ffc3e0645: [clangd] Decouple IncludeCleaner implementation from Config (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D152685?vs=

[PATCH] D152685: [clangd] Decouple IncludeCleaner implementation from Config

2023-06-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks good! Comment at: clang-tools-extra/clangd/IncludeCleaner.h:60 +issueIncludeCleanerDiagnostics(ParsedAST &AST, llvm::StringRef Code, +

[PATCH] D152685: [clangd] Decouple IncludeCleaner implementation from Config

2023-06-12 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This should hel