Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-19 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263738: For MS ABI, emit dllexport friend functions defined inline in class (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D15267?vs=46227&id=50968#toc Repository: rL LLVM http:

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-03 Thread Stephan Bergmann via cfe-commits
sberg added a comment. Can you please push this, I do not have commit access. Thanks http://reviews.llvm.org/D15267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-02 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D15267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-02 Thread Stephan Bergmann via cfe-commits
sberg added a comment. friendly ping http://reviews.llvm.org/D15267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-01-27 Thread Stephan Bergmann via cfe-commits
sberg updated this revision to Diff 46227. sberg added a comment. updated as discussed in the comments http://reviews.llvm.org/D15267 Files: include/clang/AST/ASTConsumer.h include/clang/Frontend/MultiplexConsumer.h include/clang/Sema/Sema.h lib/CodeGen/CodeGenAction.cpp lib/CodeGen/M

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-01-27 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: include/clang/AST/ASTConsumer.h:58-64 @@ -57,5 +57,9 @@ /// \brief This callback is invoked each time an inline method definition is /// completed. virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {} + /// \brief This

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-01-27 Thread Stephan Bergmann via cfe-commits
sberg added inline comments. Comment at: include/clang/AST/ASTConsumer.h:58-64 @@ -57,5 +57,9 @@ /// \brief This callback is invoked each time an inline method definition is /// completed. virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {} + /// \brief Th

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-01-27 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: include/clang/AST/ASTConsumer.h:58-64 @@ -57,5 +57,9 @@ /// \brief This callback is invoked each time an inline method definition is /// completed. virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {} + /// \brief This

[PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2015-12-06 Thread Stephan Bergmann via cfe-commits
sberg created this revision. sberg added a reviewer: cfe-commits. ...as that is apparently what MSVC does http://reviews.llvm.org/D15267 Files: include/clang/AST/ASTConsumer.h include/clang/Frontend/MultiplexConsumer.h include/clang/Sema/Sema.h lib/CodeGen/CodeGenAction.cpp lib/CodeGen