[PATCH] D152570: [clang] Fix filename remapping in template arguments

2023-06-12 Thread Dan McGregor via Phabricator via cfe-commits
dankm added a comment. Maybe for the description something like: Apply -fmacro-prefix-map to anonymous tags in template arguments Do I need to mention TypePrinter? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.o

[PATCH] D152570: [clang] Fix filename remapping in template arguments

2023-06-12 Thread Dan McGregor via Phabricator via cfe-commits
dankm updated this revision to Diff 530763. dankm added a comment. Renamed & cleaned up unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Expr

[PATCH] D152570: [clang] Fix filename remapping in template arguments

2023-06-12 Thread Dan McGregor via Phabricator via cfe-commits
dankm added a comment. Avoiding "Fix" in the description is a good suggestion. Whether it's a bugfix or not is a matter of perspective, and what's really happening here is I'm adjusting compliant implementation defined behavior, not really fixing it. Comment at: clang/test/Co

[PATCH] D152570: [clang] Fix filename remapping in template arguments

2023-06-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! > [clang] Fix filename remapping in template arguments Personally I don't consider this a bug fix, but this changes does move into a desired direction, by making `-fmacro-prefi

[PATCH] D152570: [clang] Fix filename remapping in template arguments

2023-06-12 Thread Dan McGregor via Phabricator via cfe-commits
dankm updated this revision to Diff 530638. dankm added a comment. Fix unit tests on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Expr.cpp

[PATCH] D152570: [clang] Fix filename remapping in template arguments

2023-06-12 Thread Dan McGregor via Phabricator via cfe-commits
dankm updated this revision to Diff 530563. dankm added a comment. Rebase and hopefully fix builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Exp