[PATCH] D152443: Add operator style options to clang-format

2023-06-12 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4203 return true; - -if (Left.is(tok::kw_operator)) - return Right.is(tok::coloncolon); +// Operator overloads, calls and address-of expressions +if (Left.is(tok::kw_

[PATCH] D152443: Add operator style options to clang-format

2023-06-12 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. did you cover the case where I have a namespaced, static foo::Bar->operator==() foo::Bar->m_oper->operator==() foo::Bar->m_oper.operator==() foo::Bar.operator==() Comment at: clang/lib/Format/TokenAnnotator.cpp:4207-4210 +if (!To

[PATCH] D152443: Add operator style options to clang-format

2023-06-11 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 530348. KitsuneAlex marked 2 inline comments as done. KitsuneAlex added a comment. Fix broken style in TokenAnnotator.cpp. I don't know how i keep missing these, trying to get better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D152443: Add operator style options to clang-format

2023-06-11 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 530346. KitsuneAlex marked 4 inline comments as done. KitsuneAlex added a comment. Added missing test case for default operator declarations as requested, as well as blank lines between the blocks inside the test functions as visual separators. Reposito

[PATCH] D152443: Add operator style options to clang-format

2023-06-11 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 530343. KitsuneAlex added a comment. Revamped the formatting logic again and added the requested unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/ https://reviews.llvm.org/D152443 Files