[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 529788. KitsuneAlex added a comment. Applied all suggested changes and added a suiting option for aformentioned edge-case for call expressions. Also added the missing release notes to the apropriate section. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex added a comment. In D152443#4406923 , @HazardyKnusperkeks wrote: > Can you add a note to the release notes also please? Of course! Doing that right now :) Another thing i was wondering was if it would make sense to add a separate option fo

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

2023-06-08 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Can you add a note to the release notes also please? Comment at: clang/include/clang/Format/Format.h:3709 + /// \version 17 + bool SpaceAfterOperatorKeyword; + O before T, please resort. Comment at: clang

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 529635. KitsuneAlex added a comment. I took the liberty and extended the unit tests for SpaceAfterTemplateKeyword and SpaceAfterOperator keyword to cover both possible cases, which lead to me discovering that my code was not quite right because of an ear

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex updated this revision to Diff 529587. KitsuneAlex added a comment. I removed the redundant anonymous parameter in the unit test source string. Locally all formatting tests passed fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15244

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex added a comment. I made a stupid mistake and messed up the formatting of the anonymous parameter in the unit test code. Fixing this right now, don't know why it slipped through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

2023-06-08 Thread Alexander Hinze via Phabricator via cfe-commits
KitsuneAlex created this revision. KitsuneAlex added reviewers: lattner, craig.topper, RKSimon, respindola. KitsuneAlex added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperD