[PATCH] D152401: CGExprCXX: emit family and allockind attributes

2023-06-13 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. > As a result, clang/llvm should correctly > optimize custom allocators like this without needing specialized > knowledge going forward. Not exactly: we still need knowledge of this in //clang// (`isReplaceableGlobalAllocationFunction` was taught that the variant with a

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

2023-06-13 Thread Augie Fackler via Phabricator via cfe-commits
durin42 added a comment. FYI: this is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152401/new/ https://reviews.llvm.org/D152401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

2023-06-08 Thread Augie Fackler via Phabricator via cfe-commits
durin42 edited the summary of this revision. durin42 updated this revision to Diff 529617. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152401/new/ https://reviews.llvm.org/D152401 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenCXX/cx

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

2023-06-07 Thread Augie Fackler via Phabricator via cfe-commits
durin42 created this revision. Herald added subscribers: JDevlieghere, hiraditya. Herald added a project: All. durin42 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This allows us to remove most of the special knowledge