Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

2015-12-04 Thread Alexey Samsonov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254771: [Docs] Move the list of CFI schemes down to CFI doc, and update it. (authored by samsonov). Changed prior to commit: http://reviews.llvm.org/D15237?vs=41905&id=41933#toc Repository: rL LLVM

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

2015-12-04 Thread Peter Collingbourne via cfe-commits
pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

2015-12-04 Thread Alexey Samsonov via cfe-commits
samsonov added inline comments. Comment at: docs/ControlFlowIntegrity.rst:23 @@ -22,6 +22,3 @@ To enable Clang's available CFI schemes, use the flag ``-fsanitize=cfi``. -As currently implemented, all of Clang's CFI schemes (``cfi-vcall``, -``cfi-derived-cast``, ``cfi-unrelated-ca

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

2015-12-04 Thread Alexey Samsonov via cfe-commits
samsonov updated this revision to Diff 41905. samsonov marked 3 inline comments as done. samsonov added a comment. - Address pcc's comments. http://reviews.llvm.org/D15237 Files: docs/ControlFlowIntegrity.rst docs/UsersManual.rst Index: docs/UsersManual.rst

Re: [PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

2015-12-04 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: docs/ControlFlowIntegrity.rst:23 @@ -22,6 +22,3 @@ To enable Clang's available CFI schemes, use the flag ``-fsanitize=cfi``. -As currently implemented, all of Clang's CFI schemes (``cfi-vcall``, -``cfi-derived-cast``, ``cfi-unrelated-cast``,

[PATCH] D15237: [Docs] Use proper headling levels in CFI doc.

2015-12-04 Thread Alexey Samsonov via cfe-commits
samsonov created this revision. samsonov added reviewers: pcc, kcc. samsonov added a subscriber: cfe-commits. Before that, all sections were considered a subsection of "Introduction". [Docs] Move the list of CFI schemes down to CFI doc, and update it. http://reviews.llvm.org/D15237 Files: doc