[PATCH] D152351: [clang] Add __builtin_isfpclass

This revision was automatically updated to reflect the committed changes. Closed by commit rG7dd387d2971d: [clang] Add __builtin_isfpclass (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D152351?vs=530772&id=532477#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D152351: [clang] Add __builtin_isfpclass

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Clang bits LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 __

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff marked 2 inline comments as done. sepavloff added inline comments. Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + +_Bool check_isfpclass_finite(float x) { arsenm wrot

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff updated this revision to Diff 530772. sepavloff added a comment. Herald added subscribers: aheejin, dschuff. Updated patch - Added named constants for data classes, - Fixed documentation, - Changed test for generated IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152351: [clang] Add __builtin_isfpclass

tschuett added a comment. Could Clang offer a builtin.h file? It is always included. You place named constants and enums inside. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 __

[PATCH] D152351: [clang] Add __builtin_isfpclass

arsenm added inline comments. Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + +_Bool check_isfpclass_finite(float x) { sepavloff wrote: > arsenm wrote: > > Can you also add a h

[PATCH] D152351: [clang] Add __builtin_isfpclass

aaron.ballman added a comment. In D152351#4409725 , @sepavloff wrote: > In D152351#4403904 , @aaron.ballman > wrote: > >> In D152351#4402785 , @arsenm wrote: >> >>> Also

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff marked 8 inline comments as done. sepavloff added a comment. In D152351#4403904 , @aaron.ballman wrote: > In D152351#4402785 , @arsenm wrote: > >> Also should get mentioned in the builtin docs and relea

[PATCH] D152351: [clang] Add __builtin_isfpclass

arsenm added a comment. Typo builting in commit message Comment at: clang/docs/LanguageExtensions.rst:3418 + +This function never raises floating-point exceptions. + Maybe also mention it doesn't canonicalize its input Comment at: clang/test/

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff updated this revision to Diff 530041. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNote

[PATCH] D152351: [clang] Add __builtin_isfpclass

aaron.ballman added a comment. In D152351#4402785 , @arsenm wrote: > Also should get mentioned in the builtin docs and release notes +1, also, should there be named constants for the mask values? Comment at: clang/include/clang/Basic/

[PATCH] D152351: [clang] Add __builtin_isfpclass

arsenm added a comment. Also should get mentioned in the builtin docs and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 ___ cfe-commits mailing

[PATCH] D152351: [clang] Add __builtin_isfpclass

arsenm added inline comments. Comment at: clang/test/CodeGen/isfpclass.c:1 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + Use generated checks? Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %cla

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff added a comment. In D152351#4402615 , @qiucf wrote: > It's necessary to check range of first argument in `SemaChecking.cpp` using > `SemaBuiltinConstantArgRange`. > > _Bool check_isfpclass_1(float x) { return __builtin_isfpclass(123456, x); }

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff updated this revision to Diff 529243. sepavloff added a comment. Add check for test bit mask value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D152351: [clang] Add __builtin_isfpclass

qiucf added a comment. It's necessary to check range of first argument in `SemaChecking.cpp` using `SemaBuiltinConstantArgRange`. _Bool check_isfpclass_1(float x) { return __builtin_isfpclass(123456, x); } // ICE int g; // error: cannot compile this builtin function yet // there's be

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff created this revision. sepavloff added reviewers: rjmccall, aaron.ballman, arsenm, kpn, qiucf, efriedma. Herald added a subscriber: hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added subscribers: llvm-commits, wdng. Herald added projects: cl