This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4d0cfa6d09e2: [clang] Don't create import decls without
-fmodules (authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D15227
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
The internal state when modules are off but layering check is on is really
counterintuitive, and clearly not all configurations have been tested :-(
I'm pretty sure this is the right beha
ChuanqiXu added inline comments.
Comment at: clang/test/Modules/getSourceDescriptor-crash.cpp:2
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -I %S/Inputs/getSourceDescriptor-crash -S -emit-llvm
-debug-info-kind=limited -debugger-tuning=lldb -fmodules
-fmodules-cache-path=%t -fimplici
kadircet updated this revision to Diff 528863.
kadircet added a comment.
- Test layering check violation diagnostics
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152274/new/
https://reviews.llvm.org/D152274
Files:
clang/lib/Sema/SemaModule.cpp
kadircet added a comment.
@dblaikie this also updates `getSourceDescriptor-crash.cpp`, which was making
use of generation of implicit import decl. I assumed that test is trying to
make sure `ImportDecl` is represented properly, and incidentally relied on
implicit generation of it. LMK if that i
kadircet created this revision.
kadircet added reviewers: sammccall, dblaikie.
Herald added a subscriber: ChuanqiXu.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When modules are disabled, there's no
