[PATCH] D152259: [Clang] Make increment bool SFINAE-friendly

2023-06-06 Thread Yurong via Phabricator via cfe-commits
yronglin marked an inline comment as done. yronglin added a comment. In D152259#4399217 , @erichkeane wrote: > This should have a release note. > > I think the bug is asking to make this a SFINAE failure (it isn't clear what > you mean by "SFINAE Friend

[PATCH] D152259: [Clang] Make increment bool SFINAE-friendly

2023-06-06 Thread Yurong via Phabricator via cfe-commits
yronglin updated this revision to Diff 528847. yronglin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152259/new/ https://reviews.llvm.org/D152259 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/

[PATCH] D152259: [Clang] Make increment bool SFINAE-friendly

2023-06-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. This should have a release note. I think the bug is asking to make this a SFINAE failure (it isn't clear what you mean by "SFINAE Friendly"). Our mechanism for that is to mark the diagnostic SFINAEError. Comment at: clang/lib/Sema/SemaExpr.cpp:14

[PATCH] D152259: [Clang] Make increment bool SFINAE-friendly

2023-06-06 Thread Yurong via Phabricator via cfe-commits
yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yronglin Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152259 Files: clang/lib/Sem