[PATCH] D152195: [Clang] Fix access of friend function in local class

2023-06-06 Thread Elizabeth Andrews via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1401e9f3e7c: [Clang][Sema] Fix access of friend class in local class (authored by eandrews). Herald added a project: clang. Changed prior to commit

[PATCH] D152195: [Clang] Fix access of friend function in local class

2023-06-06 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews updated this revision to Diff 528883. eandrews added a comment. Thanks for the review! I added a release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152195/new/ https://reviews.llvm.org/D152195 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDecl.cpp clang/t

[PATCH] D152195: [Clang] Fix access of friend function in local class

2023-06-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D152195#4399445 , @eandrews wrote: > In D152195#4399251 , @erichkeane > wrote: > >> I think the patch looks fine, but this needs a release note. > > Just so I know - Does every bug

[PATCH] D152195: [Clang] Fix access of friend function in local class

2023-06-06 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews added a comment. In D152195#4399251 , @erichkeane wrote: > I think the patch looks fine, but this needs a release note. Just so I know - Does every bug fix need a release note now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152195/

[PATCH] D152195: [Clang] Fix access of friend function in local class

2023-06-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I think the patch looks fine, but this needs a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152195/new/ https://reviews.llvm.org/D152195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D152195: [Clang] Fix access of friend function in local class

2023-06-05 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews created this revision. eandrews added reviewers: erichkeane, aaron.ballman. Herald added a project: All. eandrews requested review of this revision. Clang currently emits an error when a friend of a local class tries to access it's private data members. This patch fixes the bug. https: