nathanchance added a comment.
Thanks, I landed it with those nits addressed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152186/new/
https://reviews.llvm.org/D152186
___
cfe-commits mailing list
cfe-co
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdeecf89a1361: [Clang] Add release note for 877210faa447
(authored by nathanchance).
Changed prior to commit:
https://reviews.llvm.org/D152186?vs=5
erichkeane accepted this revision.
erichkeane added a comment.
2 nits, otherwise LGTM! Thanks!
Comment at: clang/docs/ReleaseNotes.rst:333
can be controlled using ``-fcaret-diagnostics-max-lines=``.
+- Clang no longer emits ``-Wunused-variable`` for variables declared with
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.
Thanks for the patch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152186/new/
https://reviews.llvm.org/D152186
nathanchance created this revision.
nathanchance added reviewers: erichkeane, nickdesaulniers.
Herald added a project: All.
nathanchance requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.