[PATCH] D152132: [clang][Interp] Fix lifetime diagnostics for dead records

2023-08-20 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39236e9c60e5: [clang][Interp] Fix lifetime diagnostics for dead records (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152132: [clang][Interp] Fix lifetime diagnostics for dead records

2023-08-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing lis

[PATCH] D152132: [clang][Interp] Fix lifetime diagnostics for dead records

2023-08-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 551087. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/InterpBlock.h clang/lib/AST/Interp/InterpState.cpp clang/test/AST/Interp/lifeti

[PATCH] D152132: [clang][Interp] Fix lifetime diagnostics for dead records

2023-08-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:241 bool CheckMutable(InterpState &S, CodePtr OpPC, const Pointer &Ptr) { - assert(Ptr.isLive() && "Pointer is not live"); if (!Ptr.isMutable()) { aaron.ballman wrote: > I understand