[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-12 Thread Louis Burda via Phabricator via cfe-commits
Sinitax updated this revision to Diff 530726. Sinitax added a comment. Fix test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/D

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-12 Thread Louis Burda via Phabricator via cfe-commits
Sinitax updated this revision to Diff 530501. Sinitax added a comment. Rebase patch against branch main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td cla

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-08 Thread Louis Burda via Phabricator via cfe-commits
Sinitax added a comment. > Why do you make this a new warning group instead of just adding it to > -Wuninitialized? I think a separate group is best, since the warning emits false positives: an intentional empty-initialization (such as `char buf[BUF_SIZ] = { 0 }`) is indistinguishable from uni

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-08 Thread Louis Burda via Phabricator via cfe-commits
Sinitax updated this revision to Diff 529671. Sinitax added a comment. Rebased changes onto commit tagged 'llvmorg-17-init', and added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: docs/ReleaseNotes.rst include/clan

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-08 Thread Louis Burda via Phabricator via cfe-commits
Sinitax updated this revision to Diff 529658. Sinitax added a comment. Rename warning to -Wincomplete-array-initializer-list for clarity, and add test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: include/clang/Basic/Diagnost

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Needs release notes and tests. Patch needs full-context added. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:732 def UninitializedConstReference : DiagGroup<"uninitialized-const-reference">; +def UninitializedArrayElements : DiagGroup<"

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-06 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:732 def UninitializedConstReference : DiagGroup<"uninitialized-const-reference">; +def UninitializedArrayElements : DiagGroup<"uninitialized-array-elements">; def Uninitialized : DiagGroup

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-05 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a reviewer: clang-language-wg. shafik added a comment. Adding reviewer for more visibility CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-05 Thread Louis Burda via Phabricator via cfe-commits
Sinitax updated this revision to Diff 528387. Sinitax added a comment. Apply git-clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKin

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-04 Thread Louis Burda via Phabricator via cfe-commits
Sinitax updated this revision to Diff 528256. Sinitax added a comment. Add new warning to its own group. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/Diagnos

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

2023-06-03 Thread Louis Burda via Phabricator via cfe-commits
Sinitax updated this revision to Diff 528162. Sinitax added a comment. Remove new warning from -Wuninitialized group for backwards-compatibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/include/clang/Basic/DiagnosticSema