[PATCH] D151863: [x86][MC] Fix movdir64b addressing

This revision was automatically updated to reflect the committed changes. Closed by commit rG15f15ab2c895: [x86][MC] Fix movdir64b addressing (authored by akshaykhadse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 ___ cfe

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 529491. akshaykhadse added a comment. Rename test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c clang/te

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

MaskRay added inline comments. Comment at: llvm/test/CodeGen/X86/movdir64b-inline-asm-x86_64.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2 +; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+movdir64b | FileCheck

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse marked an inline comment as done. akshaykhadse added inline comments. Comment at: llvm/test/CodeGen/X86/movdir64b-inline-asm-x86_64.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2 +; RUN: llc < %s -mtriple=x8

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

MaskRay added inline comments. Comment at: llvm/test/CodeGen/X86/movdir64b-inline-asm-x86_64.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2 +; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+movdir64b | FileCheck

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 528339. akshaykhadse added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c clang/test/

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 528311. akshaykhadse added a comment. Remove logic to set BaseReg to non-zero value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/m

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

skan added inline comments. Comment at: llvm/test/MC/X86/x86-64-movdir64b-intel.s:1 +// RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel -output-asm-variant=1 --show-encoding %s | FileCheck %s +// CHECK: movdir64b rax, zmmword ptr [rax - 4096] a

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1780 // Otherwise, we set the base register to a non-zero value - // if we don't know the actual value at this time. This is necessary to + // if we don't know the actual value at

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

skan added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1780 // Otherwise, we set the base register to a non-zero value - // if we don't know the actual value at this time. This is necessary to + // if we don't know the actual value at this ti

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: llvm/test/MC/X86/x86-64-movdir64b-intel.s:1 +// RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel -output-asm-variant=1 --show-encoding %s | FileCheck %s +// CHECK: movdir64b rax, zmmword ptr [rax - 4096] --

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

skan added inline comments. Comment at: llvm/test/MC/X86/x86-64-movdir64b-intel.s:1 +// RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel -output-asm-variant=1 --show-encoding %s | FileCheck %s +// CHECK: movdir64b rax, zmmword ptr [rax - 4096] T

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

skan added a comment. Replace the url of the picture in the summary with the plain text? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 ___ cfe-commits mailing

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added a comment. @craig.topper, @skan: Does this look good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 ___ cfe-commits mailing list cfe-commit

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527797. akshaykhadse added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c clang/test/

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527783. akshaykhadse added a comment. Implement solution mentioned in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inl

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added a comment. In D151863#4390172 , @akshaykhadse wrote: > In D151863#4390132 , @craig.topper > wrote: > >> I still think replacing the `1` with a valid register for the mode is the >> better fix

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added a comment. In D151863#4390132 , @craig.topper wrote: > I still think replacing the `1` with a valid register for the mode is the > better fix. So, should I create a new registers? Something like `X86::Sym16`, `X86::Sym32` and `X86::

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

XinWang10 added a comment. In D151863#4390132 , @craig.topper wrote: > I still think replacing the `1` with a valid register for the mode is the > better fix. But if you give that, we couldn't take a mem operand without base reg. Repository: rG LLV

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added a comment. I still think replacing the `1` with a valid register for the mode is the better fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 ___

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added a comment. If we could get rid of `BaseReg = BaseReg ? BaseReg : 1;` in `X86AsmParser::CreateMemForMSInlineAsm`, then we don't need any changes in the `X86Operand.h`. F27787125: image.png I was not able to find any failing tests after maki

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527764. akshaykhadse added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c cl

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemBaseReg() == X86::NoRegister) + return true; craig.topper wrote: > Now we're not checking the index register if there is no bas

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1781 + // value at this time. + BaseReg = BaseReg ? BaseReg : 0; Operands.push_back(X86Operand::CreateMem( craig.topper wrote: > This sets BaseReg to 0 if its alre

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemBaseReg() == X86::NoRegister) + return true; Now we're not checking the index register if there is no base register? Reposito

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1781 + // value at this time. + BaseReg = BaseReg ? BaseReg : 0; Operands.push_back(X86Operand::CreateMem( This sets BaseReg to 0 if its already 0? Repository:

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527725. akshaykhadse added a comment. Update AsmParser Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c clang/tes

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-64.c:79 + int arr[1000]; + __asm enqcmds rax, zmmword ptr [arr] + // CHECK: call void asm sideeffect inteldialect "enqcmds rax, zmmword ptr $0", "*m,~{flags},~{dirflag},~{fpsr},~{flags}"(ptr elem

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386 return false; +if (getMemDisp()->getKind() == llvm::MCExpr::SymbolRef) + return true; Wouldn't this allow "symbol + %eax" to pick the 64-bit instruction

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

XinWang10 added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-64.c:79 + int arr[1000]; + __asm enqcmds rax, zmmword ptr [arr] + // CHECK: call void asm sideeffect inteldialect "enqcmds rax, zmmword ptr $0", "*m,~{flags},~{dirflag},~{fpsr},~{flags}"(ptr element

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse added a comment. Please let me know if these tests and changes look okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 ___ cfe-commits mailing l

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527345. akshaykhadse added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add CFE tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org