[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3fbede7f3fd: [HIP] Add missing __hip_atomic_fetch_sub support (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://revie

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://reviews.llvm.org/D151701 __

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

ldrumm added a comment. In D151701#4380666 , @yaxunl wrote: > HIP did not add fetch/sub since fetch/sub x can be trivially implemented > through fetch/add -x and performance-wise equivalent. There is existing isel for `global_atomic_sub` for RDNA target

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

yaxunl added a comment. HIP did not add fetch/sub since fetch/sub x can be trivially implemented through fetch/add -x and performance-wise equivalent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://reviews.llvm.org/D151701

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

nikic resigned from this revision. nikic added a comment. (Looks reasonable, but is pretty far outside my area of expertise...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://reviews.llvm.org/D151701

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

ldrumm created this revision. ldrumm added reviewers: yaxunl, nikic, gandhi21299. Herald added a subscriber: StephenFan. Herald added a project: All. ldrumm requested review of this revision. Herald added a project: clang. The rest of the fetch/op intrinsics were added in e13246a2ec3