[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 532772. FreddyYe added a comment. Adjust atom_sse4_2_movbe test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp clang/lib

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:110 FeatureBitset Features; + char Mangling; + bool OnlyForCPUDispatchSpecific; RKSimon wrote: > Do we have a documented list of the mangling values anywhere? The values >

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:110 FeatureBitset Features; + char Mangling; + bool OnlyForCPUDispatchSpecific; Do we have a documented list of the mangling values anywhere? The values below look too much

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added a comment. Thanks for @RKSimon 's review, I'd like also to mention that https://reviews.llvm.org/D152989 is supposed to be the base commit of here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 532517. FreddyYe marked an inline comment as done. FreddyYe added a comment. Typo refine: OnlyForCPUSpecificDispath -> OnlyForCPUDispatchSpecific Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:8 ; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=pentium 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty -; RUN: llc < %s

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 532494. FreddyYe added a comment. Update cpus-intel.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/Basic/Ta

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:8 ; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=pentium 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty -; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:26 ; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=emeraldrapids 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: l

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 531993. FreddyYe added a comment. 1. Update generic and pentium Features to align with X86.td. 2. Readjust tests in cpus-intel.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:314 + // Empty processor. Include X87 and CMPXCHG8 for backwards compatibility. + { {""}, CK_None, ~0U, FeatureX87 | FeatureCMPXCHG8B, '\0', false }, + { {"generic"}, CK_None, ~0U, FeaturesPen

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:15 #include "llvm/ADT/StringSwitch.h" +#include "llvm/ADT/StringExtras.h" #include (clang-format) - include order Comment at: llvm/lib/TargetParser/X86Targe

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added a comment. This patch means to remove `CPU_SPECIFIC*` MACROs in X86TargetParser.def and move that part of functionality into X86TargetParser.cpp. Since these two files **both** maintain a table with `cpuname`, `features of this cpu supported`, ... This move can reduce the codes.

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 531615. FreddyYe added a comment. misc refine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/Basic/Targets/X86