This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf354e971b09c: [MemProf] Clean up MemProf instrumentation
pass invocation (authored by tejohnson).
Repository:
rG LLVM Github Monorepo
CHANGES SIN
snehasish accepted this revision.
snehasish added a comment.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151593/new/
https://reviews.llvm.org/D151593
___
cfe-commits mailing list
cfe-commits@lists
tejohnson added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:995
+// TODO: Consider passing the MemoryProfileOutput to the pass builder via
+// the PGOOptions, and set this up there.
vitalybuka wrote:
> tejohnson wrote:
> > vitalybuka
vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
Either way is fine
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151593/new/
https://reviews.llvm.org/D151593
_
vitalybuka added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:995
+// TODO: Consider passing the MemoryProfileOutput to the pass builder via
+// the PGOOptions, and set this up there.
tejohnson wrote:
> vitalybuka wrote:
> > if this is
tejohnson added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:995
+// TODO: Consider passing the MemoryProfileOutput to the pass builder via
+// the PGOOptions, and set this up there.
vitalybuka wrote:
> if this is registerOptimizerLast
vitalybuka added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:995
+// TODO: Consider passing the MemoryProfileOutput to the pass builder via
+// the PGOOptions, and set this up there.
if this is registerOptimizerLastEPCallback, it can
tejohnson created this revision.
tejohnson added a reviewer: snehasish.
Herald added subscribers: ormris, hiraditya.
Herald added a project: All.
tejohnson requested review of this revision.
Herald added projects: clang, LLVM.
First, removes the invocation of the memprof instrumentation passes fro
