[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 538197. SlaterLatiao added a comment. - Emit include stack on all top-level diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files: clang/docs/Rele

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

dblaikie added a comment. Judging by @aaron.ballman's comment on the bug, I can see the logic here. Though perhaps this notion generalizes to all non-note types, not just errors (like perhaps we should print the include stack for each warning, too?) Repository: rG LLVM Github Monorepo CHANG

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 531885. SlaterLatiao added a comment. Remove unnecessary condition and assignment in implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files: cla

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

erichkeane added a comment. I don't have much of an opinion on the commit itself. It seems that suppressing that include stack does at least SOME work to make our error-novels less 'War and Peace', but I don't really get the bug report well enough to know whether we should be doing this. ==

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

cjdb added subscribers: shafik, erichkeane, aaron.ballman. cjdb added a comment. @aaron.ballman @erichkeane @shafik any reservations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 __

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

denik accepted this revision. denik added a comment. This revision is now accepted and ready to land. As long as having `In file included from` on each error **without notes** from one include file is fine, I don't see any problem with this. LGTM. But let's check what others think about it. For

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 526717. SlaterLatiao added a comment. - Added release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files: clang/docs/ReleaseNotes.rst clang/lib/Fron

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

cjdb added a comment. Thanks for working on this. Would you mind adding more context to the commit description please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 526144. SlaterLatiao added a comment. - Add newline to end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files: clang/lib/Frontend/DiagnosticRendere

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixes PR#62001. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151575 Files: clang/lib/Fr