[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

2023-06-13 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. This patch is mainly for another WIP patch https://reviews.llvm.org/D151696, while I realize maybe it's too aggressive to support too many CPUs with -march, -mcpu, ... I'll reimplement the WIP patch to try to make the supports range same as before. Close this first.

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

2023-05-31 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D151537#4382811 , @LuoYuanke wrote: > In D151537#4380763 , @erichkeane > wrote: > >> I don't really see the justification here? Why do this change? If the >> intent is to just te

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

2023-05-30 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke added a comment. In D151537#4380763 , @erichkeane wrote: > I don't really see the justification here? Why do this change? If the > intent is to just test a newer architecture, we can add tests for that, not > change existing ones. KNL is d

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

2023-05-30 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I don't really see the justification here? Why do this change? If the intent is to just test a newer architecture, we can add tests for that, not change existing ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

2023-05-29 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151537/new/ https://reviews.llvm.org/D151537 _

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

2023-05-25 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151537 Files: clang/test/CodeGen/attr-cpuspecific.c I