[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

2023-05-26 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 526245. HerrCai0907 added a comment. add cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 Files: clang/lib/Sema/SemaInit.cpp clang/test/CodeGenCXX/cxx20-p

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

2023-05-26 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Yeah, I agree with Eli, there should be a cast here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515 ___ cfe-commits mailing list cfe-

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

2023-05-26 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Relevant bit of the AST: `-ExprWithCleanups 0xd16a780 'void':'void' `-CXXOperatorCallExpr 0xd16a678 'void':'void' '()' |-ImplicitCastExpr 0xd16a5a8 'void (*)(int (&&)[]) const' | `-DeclRefExpr 0xd16a528 'void (int (&&)[]) const' lvalue CXXMethod

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

2023-05-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added subscribers: efriedma, rjmccall, rnk. rnk added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4376 +.getTypePtr() +->getPointeeOrArrayElementType(); + const Type *CanonicalArgTy = g

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

2023-05-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Thank you for the patch! Please apply clang-format at least one of pre-commit failures is due to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

2023-05-25 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 created this revision. HerrCai0907 added reviewers: shafik, erichkeane, aaron.ballman. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed: https://github.com/llvm/llvm-project/issues/6