michaelplatings marked an inline comment as done.
michaelplatings added inline comments.
Comment at: clang/include/clang/Driver/MultilibBuilder.h:80
+ /// \p Flag must be a flag accepted by the driver.
+ MultilibBuilder &flag(bool Required, StringRef Flag);
p
phosek added inline comments.
Comment at: clang/include/clang/Driver/MultilibBuilder.h:80
+ /// \p Flag must be a flag accepted by the driver.
+ MultilibBuilder &flag(bool Required, StringRef Flag);
I think it would be cleaner to swap the order of arguments a
This revision was automatically updated to reflect the committed changes.
Closed by commit rG47b431d6617d: [NFC][Driver] Change MultilibBuilder interface
(authored by michaelplatings).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151437/new/
https:
simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.
LGTM: I agree that the new notation is easier to understand for anyone not
already used to the old one.
However, please wait at least a day for other people and time zones to have
michaelplatings created this revision.
michaelplatings added a reviewer: phosek.
Herald added a subscriber: abrachet.
Herald added a project: All.
michaelplatings requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Decouple the interfac
