[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added a comment. I finally got around to testing this patch on compiles of explicit modules. The number of elapsed CPU cycles decreased (by up to 1.8% for large modules) and the cumulative size of PCM files decreased by 2% (though small modules are a few bytes larger). These findin

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc68ba12abf49: [clang][modules] Mark fewer identifiers as out-of-date (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

Bigcheese accepted this revision. Bigcheese added a comment. Looks good, although I'm not an expert on this bit either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added a project: clang-modules. jansvoboda11 added a comment. Thanks, Ben. Maybe someone subscribed to `clang-modules` could take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277 _

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM, but I would prefer at least one more person who understands the identifier handling code review this. It's been years since I thought about this code. Repository: rG LLVM G

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 updated this revision to Diff 527634. jansvoboda11 added a comment. Rebase and switch back to `IdentifierTable::getOwn()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277 Files: clang/lib/Se

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4413 +// first/next use via ASTReader::updateOutOfDateIdentifier(). +II = &PP.getIdentifierTable().get(Key); + } benlangmuir wrote: > Why did this change fr

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

benlangmuir added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4413 +// first/next use via ASTReader::updateOutOfDateIdentifier(). +II = &PP.getIdentifierTable().get(Key); + } Why did this change from `getOwn` to `get`?

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In `clang-scan-deps` co