[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek added a comment. In D151186#4369203 , @MaskRay wrote: > In D151186#4369181 , @phosek wrote: > >> That alias is already recognized by the GNU driver. I'm sharing the >> implementation between the two driver

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

MaskRay added a comment. In D151186#4369181 , @phosek wrote: > That alias is already recognized by the GNU driver. I'm sharing the > implementation between the two drivers. Would you prefer to reject `-nopie` > when targeting Fuchsia? Hmm, handling `OP

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek added a comment. That alias is already recognized by the GNU driver. I'm sharing the implementation between the two drivers. Would you prefer to reject `-nopie` when targeting Fuchsia? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/ne

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

MaskRay added a comment. I suspect that OpenBSD uses `-nopie`, but this is never adopted by other OSes / GCC. And Clang should not add a new alias that has no significant uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://revi

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

mcgrathr added a comment. In GCC the spelling is `-no-pie`. `-nopie` is not documented as an alias, and I don't think it works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://reviews.llvm.org/D151186 ___

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek updated this revision to Diff 524602. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://reviews.llvm.org/D151186 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h clang/lib/Driver

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek updated this revision to Diff 524601. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://reviews.llvm.org/D151186 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h clang/lib/Driver

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek updated this revision to Diff 524599. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151186/new/ https://reviews.llvm.org/D151186 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h clang/lib/Driver

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek created this revision. phosek added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Prior to this patch we would ignore -pie and -no