This revision was automatically updated to reflect the committed changes.
Closed by commit rG42c83e32706e: [clang-tidy] Ignore implicit code in
bugprone-branch-clone (authored by PiotrZSL).
Changed prior to commit:
https://reviews.llvm.org/D151133?vs=524764&id=524845#toc
Repository:
rG LLVM
donat.nagy accepted this revision.
donat.nagy added a comment.
This revision is now accepted and ready to land.
If this freshly added testcase passes, then there is no reason to delay merging
this commit. Thanks for the contribution :) !
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
PiotrZSL updated this revision to Diff 524764.
PiotrZSL added a comment.
Add positive test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151133/new/
https://reviews.llvm.org/D151133
Files:
clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.h
donat.nagy added a comment.
For me it's an unfortunate surprise that Clang Tidy is traversing the concrete
//template instantiation// (I would've guessed that it's working on the
original template body), but if that's the observed behavior, then this commit
is a clean and straightforward fix.
PiotrZSL created this revision.
PiotrZSL added reviewers: njames93, carlosgalvezp.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Implicit code like, t
