[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-06-01 Thread Tom Eccles via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG39ecf9d8a153: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new (authored by tblah). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-06-01 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski accepted this revision. awarzynski added a comment. Thanks for the updates, LGTM! Comment at: flang/test/HLFIR/flang-experimental-hlfir-flag.f90:7-12 +! | Action | -flang-experimental-hlfir? | Result | +! | === | ===

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-06-01 Thread Tom Eccles via Phabricator via cfe-commits
tblah updated this revision to Diff 527386. tblah added a comment. Thanks again for review! Now there are two actions: - EmitFIR - EmitHLFIR EmitHLFIR will assert that lowering was set up to emit HLFIR. EmitFIR will use the HLFIR to FIR pipeline if lowering was set up to emit HLFIR. Repositor

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-05-31 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:651 +// Lower using HLFIR then run the FIR to HLFIR pipeline +void CodeGenAction::lowerHLFIRToFIR() { + assert(mlirModule && "The MLIR module has not been generated yet."); tbla

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-05-31 Thread Tom Eccles via Phabricator via cfe-commits
tblah added inline comments. Comment at: flang/include/flang/Frontend/FrontendOptions.h:42 + /// resulting FIR + EmitHLFIRToFIR, + awarzynski wrote: > To me having `EmitFIR` and `EmitHLFIR` would make more sense. With 2 > dialects, `EmitMLIR` becomes rather co

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-05-30 Thread Tom Eccles via Phabricator via cfe-commits
tblah updated this revision to Diff 526681. tblah marked an inline comment as done. tblah added a comment. Thanks for review! Changes: - Fix assertion comment - Change the -emit-mlir flag to be an alias for -emit-fir (previously they were the other way around). This does not address review comm

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-05-30 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Thanks Tom, mostly makes sense, but I suggest the following: - `EmitMLIR` --> `EmitFIR` (nfc, just clarifying the name), - `EmitHLFIRToFIR` --> `EmitHLFIR` (functional change). More comments inline. Comment at: flang/include/flang/Frontend/Frontend

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-05-30 Thread Tom Eccles via Phabricator via cfe-commits
tblah added a comment. @awarzynski ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/ https://reviews.llvm.org/D151088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

2023-05-22 Thread Slava Zakharin via Phabricator via cfe-commits
vzakhari accepted this revision. vzakhari added a comment. Thank you for the follow-up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/ https://reviews.llvm.org/D151088 ___ cfe-commits mailing

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir

2023-05-22 Thread Jean Perier via Phabricator via cfe-commits
jeanPerier accepted this revision. jeanPerier added a comment. This revision is now accepted and ready to land. Not the driver expert here, so please wait for @awarzynski input, but the new flag logic LGTM from a user point of view. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir

2023-05-22 Thread Tom Eccles via Phabricator via cfe-commits
tblah created this revision. tblah added reviewers: awarzynski, vzakhari, jeanPerier, clementval. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. tblah requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. H