This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6b50e87f21e1: [clang] Fix label (de-)serialization in ASM
statements. (authored by VitaNuo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
VitaNuo updated this revision to Diff 524342.
VitaNuo marked 2 inline comments as done.
VitaNuo added a comment.
Update test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151073/new/
https://reviews.llvm.org/D151073
Files:
clang/lib/Serial
kadircet added inline comments.
Comment at: clang/test/PCH/asm-label.cpp:5
+#define HEADER_H
+#pragma once
+void MyMethod() {
you can drop `#pragma once` know, as it won't be parsed again anyways
Comment at: clang/test/PCH/asm-label.cpp:6
+#pra
VitaNuo updated this revision to Diff 524211.
VitaNuo added a comment.
Remove template param.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151073/new/
https://reviews.llvm.org/D151073
Files:
clang/lib/Serialization/ASTReaderStmt.cpp
clang/lib
VitaNuo created this revision.
Herald added a project: All.
VitaNuo requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D151073
Files:
clang/lib/Serialization/ASTReaderStmt.cpp