[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-23 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. In D151042#4364149 , @thakis wrote: > In fact, you can probably repro the test failure on your linux box if you > change that test and add locally add -triple=i386-pc-win32 to the RUN line You're right, MSVC-specific triple make

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-23 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D151042#4364131 , @Endill wrote: > All tests pass for me on Linux. > As far as I understand, diagnostics on Windows are not supposed to be > different given the same `-cc1` flags. Reverting for further investigation. Thanks fo

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-23 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. All tests pass for me on Linux. As far as I understand, diagnostics on Windows are not supposed to be different given the same `-cc1` flags. Reverting for further investigation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-23 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. On my bots (which cover linux, mac/arm, and windows), it's only failing on the windows bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151042/new/ https://reviews.llvm.org/D151042 ___

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-23 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. In D151042#4364108 , @thakis wrote: > This breaks check-clang on windows: http://45.33.8.238/win/78827/step_7.txt > > Please take a look and revert for now if it takes a while to fix. It's not hard to fix, but is it just windows?

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-23 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks check-clang on windows: http://45.33.8.238/win/78827/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151042/new/ https://reviews.llvm.or

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-23 Thread Vlad Serebrennikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85452b5f9b5a: [clang] Add tests for CWG issues 977, 1482, 2516 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-22 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151042/new/ https://reviews.llvm.org/D151042 ___

[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

2023-05-20 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CWG977 focus on point of /completeness/ of enums. Wording provided in CWG14