[PATCH] D151040: [NFC][CLANG] Fix static code analyzer concerns

2023-05-23 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG64e9ba7048b8: [NFC][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151040/new/ https://reviews.

[PATCH] D151040: [NFC][CLANG] Fix static code analyzer concerns

2023-05-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 524291. Manna added a comment. Thank you @erichkeane for reviews. I have updated patch to avoid regression if the LValue doesn't evaluate right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151040/new/ https://reviews.llvm.org/D151040 Files: clan

[PATCH] D151040: [NFC][CLANG] Fix static code analyzer concerns

2023-05-22 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10172 Info.Ctx.getAsConstantArrayType(E->getSubExpr()->getType()); + assert(ArrayType && "unexpected type for array initializer"); I think this ends up being a regression if th