[PATCH] D151034: [clang] Add test for CWG1397

2023-05-30 Thread Vlad Serebrennikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9c561e8f3c2e: [clang] Add test for CWG1397 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151034/new/ https://reviews.llvm.org/D151034

[PATCH] D151034: [clang] Add test for CWG1397

2023-05-22 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. Thank you for the review! Comment at: clang/test/CXX/drs/dr13xx.cpp:488 +#if __cplusplus == 201103L + // expected-error@#dr1397-struct-A {{default member initializer for 'p' needed within definition of enclosing class 'A' outside of member functions}}

[PATCH] D151034: [clang] Add test for CWG1397

2023-05-22 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr13xx.cpp:488 +#if __cplusplus == 201103L + // expected-error@#dr1397-struct-A {{default member initializer for 'p' needed within definition of enclosing class 'A' outside of member functions}} + // expected-note@#d

[PATCH] D151034: [clang] Add test for CWG1397

2023-05-22 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151034/new/ https://reviews.llvm.org/D151034 ___

[PATCH] D151034: [clang] Add test for CWG1397

2023-05-20 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Resolution of this CWG breaks potential dependency loop between complete-cl