Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

2016-01-11 Thread Akira Hatanaka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257357: [Sema] Issue a warning for integer overflow in struct initializer (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D15097?vs=41451&id=44521#toc Repository: rL LLVM ht

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

2016-01-09 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. OK, thank you for the review. I'll commit this patch in a day or two unless someone comes up with a better solution. http://reviews.llvm.org/D15097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

2016-01-08 Thread Vedant Kumar via cfe-commits
vsk added a subscriber: vsk. vsk added a comment. Looks good to me. Caveat: This isn't quite my area. This seems reasonable given what I've read in `EvaluateForOverflow` and `EvaluateAsRValue`. I think you should be fine to commit if no one objects soon. http://reviews.llvm.org/D15097

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

2016-01-08 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. ping http://reviews.llvm.org/D15097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

2015-12-14 Thread Akira Hatanaka via cfe-commits
ping On Mon, Nov 30, 2015 at 4:30 PM, Akira Hatanaka wrote: > ahatanak created this revision. > ahatanak added a subscriber: cfe-commits. > > Issue a warning if an initializing integer expression overflows. > > For example, clang should issue a warning when compiling the following > code because

[PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

2015-11-30 Thread Akira Hatanaka via cfe-commits
ahatanak created this revision. ahatanak added a subscriber: cfe-commits. Issue a warning if an initializing integer expression overflows. For example, clang should issue a warning when compiling the following code because 4 * 1024 * 1024 * 1024 doesn't fit into a 32-bit integer: struct s { uns