[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

2023-11-16 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D150930#4656909 , @brunodf wrote: > Hi, > > I found this review request and I just want to comment that I find it strange > that it was rejected. > > @MaskRay I understand that using a compile_commands.json configured for gcc

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

2023-11-16 Thread Bruno De Fraine via Phabricator via cfe-commits
brunodf added a comment. Hi, I found this review request and I just want to comment that I find it strange that it was rejected. @MaskRay I understand that using a compile_commands.json configured for gcc with clang-based tools is not a supported use case, but still the clang driver was expli

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

2023-05-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D150930#4356732 , @jhuber6 wrote: > In D150930#4355240 , @MaskRay wrote: > >> Note: for options controlling individual optimization behaviors, there is a >> large probability that they

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

2023-05-19 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D150930#4355240 , @MaskRay wrote: > Note: for options controlling individual optimization behaviors, there is a > large probability that they may not make sense for Clang since the two > compilers' internals are so different.

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

2023-05-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. I object to parse and ignore this GCC option, which appears obscure. Clang traditionally added many `clang_ignored_gcc_optimization_f_Group` and `IgnoredGCCCompat` options to suppor

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

2023-05-18 Thread Sam James via Phabricator via cfe-commits
thesamesam added a comment. This is just a draft which I've only briefly tested so far. I'm wondering if this is the right place to put the option, as i've not had to write anything in tablegen before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

2023-05-18 Thread Sam James via Phabricator via cfe-commits
thesamesam created this revision. thesamesam added reviewers: MaskRay, jhuber6, tstellar. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since 47f5c54f997a59bb2c65abe6b8b811f6e7553456