Re: [PATCH] D15089: Patch to google checks in clang-tidy

2016-05-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Anyways, committed all useful changes from here in r270033. Thank you for the patch! Repository: rL LLVM http://reviews.llvm.org/D15089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D15089: Patch to google checks in clang-tidy

2016-05-19 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. As Eugene noted, the patch is seriously out of date. The only place where an old URL is still used, is docs/clang-tidy/checks/google-runtime-int.rst. However, we should check if styl

Re: [PATCH] D15089: Patch to google checks in clang-tidy

2016-05-19 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM http://reviews.llvm.org/D15089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D15089: Patch to google checks in clang-tidy

2016-05-18 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please update you patch to current code. Looks like addresses were fixed in files where they existed, but still need to be added to files without them. Repository: rL LLVM http://reviews.llvm.org/D15089 ___