This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG533af6e5c4b3: [AIX] make integrated-as as default on AIX.
(authored by Esme).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
Esme updated this revision to Diff 534884.
Esme added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150758/new/
https://reviews.llvm.org/D150758
Files:
clang/lib/Driver/ToolChains/AIX.h
clang/test/Driver/aix-as.c
clang/tes
Esme added inline comments.
Comment at: clang/test/Driver/aix-integrated-as.c:9
+// CHECK-IAS32: "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" "-emit-obj"
+// CHECK-IAS32: "aix-integrated-as.o"
+
DiggerLin wrote:
> both -fno-integrated-as and -fintegrated-as output t
Esme updated this revision to Diff 526545.
Esme added a comment.
Remove unnecessary check lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150758/new/
https://reviews.llvm.org/D150758
Files:
clang/lib/Driver/ToolChains/AIX.h
clang/test/Dri
DiggerLin added inline comments.
Comment at: clang/test/Driver/aix-integrated-as.c:9
+// CHECK-IAS32: "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" "-emit-obj"
+// CHECK-IAS32: "aix-integrated-as.o"
+
both -fno-integrated-as and -fintegrated-as output the same file n
Esme updated this revision to Diff 524641.
Esme added a comment.
Separate the backend changes from this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150758/new/
https://reviews.llvm.org/D150758
Files:
clang/lib/Driver/ToolChains/AIX.h
shchenz added inline comments.
Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:55
HasDotTypeDotSizeDirective = false;
- UseIntegratedAssembler = false;
+ UseIntegratedAssembler = true;
ParseInlineAsmUsingAsmParser = true;
brad wrote:
> Instead of setting the v
brad added inline comments.
Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:55
HasDotTypeDotSizeDirective = false;
- UseIntegratedAssembler = false;
+ UseIntegratedAssembler = true;
ParseInlineAsmUsingAsmParser = true;
Instead of setting the value to true you
Esme created this revision.
Esme added reviewers: shchenz, DiggerLin, hubert.reinterpretcast, PowerPC.
Herald added a subscriber: hiraditya.
Herald added a project: All.
Esme requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay.
Herald added projects: clan
