Amir added a comment.
Please retitle as "[BOLT][CMake] ..."
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150752/new/
https://reviews.llvm.org/D150752
___
cfe-commits mailing list
cfe-commits@lists.llvm.
michaelplatings accepted this revision.
michaelplatings added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: bolt/CMakeLists.txt:88
+ if(CMAKE_SYSROOT)
+list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT})
+ endif()
phose
phosek added inline comments.
Comment at: bolt/CMakeLists.txt:88
+ if(CMAKE_SYSROOT)
+list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT})
+ endif()
michaelplatings wrote:
> michaelplatings wrote:
> > The [[
> > https://cmake.org/cmake/help/latest/vari
phosek updated this revision to Diff 523691.
phosek marked 3 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150752/new/
https://reviews.llvm.org/D150752
Files:
bolt/CMakeLists.txt
bolt/runtime/CMakeLists.txt
clang/cmake
michaelplatings added inline comments.
Comment at: bolt/CMakeLists.txt:88
+ if(CMAKE_SYSROOT)
+list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT})
+ endif()
The [[ https://cmake.org/cmake/help/latest/variable/CMAKE_TOOLCHAIN_FILE.html |
documentation
phosek created this revision.
phosek added a reviewer: Amir.
Herald added subscribers: treapster, ayermolo, abrachet.
Herald added a reviewer: rafauler.
Herald added a reviewer: maksfb.
Herald added a project: All.
phosek requested review of this revision.
Herald added subscribers: cfe-commits, yot
