[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

Manna added a comment. Thank you everyone for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e12f5ab2df1: [CLANG] Fix uninitialized scalar field issues (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.l

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

tahonermann accepted this revision. tahonermann added a comment. > is it ok to land this patch? No objection from me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list cfe

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

schittir added a comment. @tahonermann @shafik - is it ok to land this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1190 class ParseScopeFlags { Scope *CurScope; +unsigned OldFlags = 0; tahonermann wrote: > shafik wrote: > > @tahonermann I feel like we should have a default member initializ

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

tahonermann added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1190 class ParseScopeFlags { Scope *CurScope; +unsigned OldFlags = 0; shafik wrote: > @tahonermann I feel like we should have a default member initializer for any > mem

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

shafik added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1190 class ParseScopeFlags { Scope *CurScope; +unsigned OldFlags = 0; @tahonermann I feel like we should have a default member initializer for any member that by default is

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

tahonermann added a comment. I'm not opposed to these changes, but please note that these changes mean is will no longer be possible to use ubsan to discover when these data members are used before having been assigned an appropriate value. That is only a concern when an appropriate value would

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna marked an inline comment as done. Manna added a comment. @steakhal, do you have any more concerns with StaticAnalyzer changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits ma

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp:187 - AggressivenessKind Aggressiveness; + AggressivenessKind Aggressiveness = AK_Invalid; steakhal wrote: > By looking at the

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna added a comment. In D150744#4350198 , @erichkeane wrote: > CFE changes look fine to me! Thank you @erichkeane for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 _

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna added a comment. In D150744#4350048 , @steakhal wrote: > > In our case, we initialized that field from the registration function, like > this: > > void ento::registerMoveChecker(CheckerManager &mgr) { > MoveChecker *chk = mgr.registerChec

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. CFE changes look fine to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-co

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna updated this revision to Diff 523071. Manna added a comment. Thank you @steakhal for reviews. I have addressed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h cl

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

steakhal added a comment. Speaking of the `StaticAnalyzer`, I think setting some default value is a fair point, and I think it's a good practice. In our case, we initialized that field from the registration function, like this: void ento::registerMoveChecker(CheckerManager &mgr) { MoveChe

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 523030. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGOpe

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 523025. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGOpe

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 522877. Herald added subscribers: steakhal, martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h clang/lib/A

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna created this revision. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang