aaron.ballman added a comment.
Also, precommit CI found valid test failures that need to be addressed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150740/new/
https://reviews.llvm.org/D150740
___
cfe-commits mailing list
cfe-commits@lists.l
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
The changes are missing Sema tests for diagnosing incorrect appertainment,
arguments, etc. It would also be good to have a CodeGen test showing the
behavior works on an
paquette updated this revision to Diff 522894.
paquette added a comment.
Also support blocks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150740/new/
https://reviews.llvm.org/D150740
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/lib/CodeGen
paquette added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:1474
+ let Spellings = [Clang<"nooutline">];
+ let Subjects = SubjectList<[Function, ObjCMethod]>;
+ let Documentation = [NoOutlineDocs];
jroelofs wrote:
> does it make sense on `Blo
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/include/clang/Basic/Attr.td:1474
+ let Spellings = [Clang<"nooutline">];
+ let Subjects = SubjectList<[Function, ObjCMethod]>;
+ let Documentati
paquette created this revision.
paquette added reviewers: fhahn, aemerson, jroelofs, arphaman, ahatanak.
paquette added a project: clang.
Herald added a reviewer: aaron.ballman.
Herald added a subscriber: StephenFan.
Herald added a project: All.
paquette requested review of this revision.
Sometime
