Re: [PATCH] D15070: [mips] Added support for -Wa, -mips32 and similar.

2015-12-18 Thread Daniel Sanders via cfe-commits
dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. With a couple small changes it will LGTM Comment at: lib/Driver/Tools.cpp:2567-2568 @@ -2547,1 +2566,4 @@ } + StringRef MipsFeatureStringRef = MipsTargetFeature; + if

Re: [PATCH] D15070: [mips] Added support for -Wa, -mips32 and similar.

2015-12-17 Thread Scott Egerton via cfe-commits
s.egerton updated this revision to Diff 43131. s.egerton marked 4 inline comments as done. s.egerton added a comment. Responded to reviewers comments. The -mips* option is now saved until all arguments have been parsed. The last -mips* option is the only one pushed back. The tests are now update

Re: [PATCH] D15070: [mips] Added support for -Wa, -mips32 and similar.

2015-12-16 Thread Daniel Sanders via cfe-commits
dsanders requested changes to this revision. This revision now requires changes to proceed. Comment at: lib/Driver/Tools.cpp:2501-2524 @@ -2500,2 +2500,26 @@ } + +const char *Feature = llvm::StringSwitch(Value) + .Case("-mips1", "+

[PATCH] D15070: [mips] Added support for -Wa,-mips32 and similar.

2015-11-30 Thread Scott Egerton via cfe-commits
s.egerton created this revision. s.egerton added reviewers: dsanders, vkalintiris. s.egerton added a subscriber: cfe-commits. http://reviews.llvm.org/D15070 Files: lib/Driver/Tools.cpp test/Driver/mips-ias-Wa.s Index: test/Driver/mips-ias-Wa.s