This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
mboehme marked an inline comment as done.
Closed by commit rG96b22e1c378a: [clang][dataflow] Use `Strict` accessors in
SignAnalysisTest.cpp. (authored by mboehme).
Rep
mboehme marked 2 inline comments as done.
mboehme added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240
+// Returns the `Value` associated with `E` (which may be either a prvalue or
+// glvalue). Creates a `Value` or `StorageLocation
xazax.hun accepted this revision.
xazax.hun added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:134
LatticeTransferState &State) {
- StorageLocation *Loc = State.Env.getStorageLocation(*BO, SkipPast::None);
- if (!
sammccall added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240
+// Returns the `Value` associated with `E` (which may be either a prvalue or
+// glvalue). Creates a `Value` or `StorageLocation` as needed if `E` does not
mboehme added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240
+// Returns the `Value` associated with `E` (which may be either a prvalue or
+// glvalue). Creates a `Value` or `StorageLocation` as needed if `E` does not
--
mboehme updated this revision to Diff 522554.
mboehme added a comment.
Added a comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150657/new/
https://reviews.llvm.org/D150657
Files:
clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240
+// Returns the `Value` associated with `E` (which may be either a prvalue or
+// glva
mboehme created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch is part of the ongoing migration to strict handling of value
catego
