[PATCH] D150645: [Driver] Support multi /guard: options

pengfei added a comment. In D150645#4379536 , @glandium wrote: > In D150645#4351266 , @aeubanks > wrote: > >> this causes `./build/rel/bin/clang-cl /c /tmp/a.cc /Fo/tmp/a >> /guard:cf,nochecks` to go from no war

[PATCH] D150645: [Driver] Support multi /guard: options

glandium added a comment. In D150645#4351266 , @aeubanks wrote: > this causes `./build/rel/bin/clang-cl /c /tmp/a.cc /Fo/tmp/a > /guard:cf,nochecks` to go from no warnings to > > clang-cl: warning: argument unused during compilation: '/guard:cf,nocheck

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei added a comment. Sorry for the back and forth! I just want to add a `:` after `warning`, but I forgot to amend it in the first reland.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645 ___

[PATCH] D150645: [Driver] Support multi /guard: options

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f366dcd85c: Reland "[Driver] Support multi /guard: options" (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://revie

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei updated this revision to Diff 523745. pengfei added a comment. In D150645#4353408 , @aeubanks wrote: > if you add a test for the repro, relanding lgtm Thanks, done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D150645: [Driver] Support multi /guard: options

aeubanks added a comment. if you add a test for the repro, relanding lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645 ___ cfe-commits mailing list cfe-commi

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei updated this revision to Diff 523256. pengfei added a comment. Sorry for the noise, I guess I missed a `A->claim()` here. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645 Files: clang/li

[PATCH] D150645: [Driver] Support multi /guard: options

aeubanks added a comment. this causes `./build/rel/bin/clang-cl /c /tmp/a.cc /Fo/tmp/a /guard:cf,nochecks` to go from no warnings to clang-cl: warning: argument unused during compilation: '/guard:cf,nochecks' [-Wunused-command-line-argument] Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei added a comment. Thanks @rnk ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D150645: [Driver] Support multi /guard: options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b6f7e45a209: [Driver] Support multi /guard: options (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D150645: [Driver] Support multi /guard: options

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei created this revision. pengfei added reviewers: rnk, arlosi, thakis, ajpaverd. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.