[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

This revision was automatically updated to reflect the committed changes. Closed by commit rG6eb6ee3cfe57: [clang-tidy] Move formatDereference to FixitHintUtils (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe updated this revision to Diff 530943. mikecrowe added a comment. Move clangTooling to clang_target_link_libraries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 Files: clang-tools-extra/clang

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL added a comment. I think it should be under clang_target_link_libraries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 ___ cfe-commits mailing list cf

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe updated this revision to Diff 530662. mikecrowe added a comment. Add clangTooling to LINK_LIBS for tooling::fixit::getText for clangTidyUtils to fix failure to build with BUILD_SHARED_LIBS=ON: ld.lld: error: undefined symbol: clang::tooling::fixit::internal::getText(clang::CharSourc

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL reopened this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Looks like there is missing dependency in CMake: https://lab.llvm.org/buildbot/#/builders/57/builds/27531 FAILED: lib/libclangTidyUtils.so.17git : && /home/buildbots/clang.15.0.4/bin/c

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

This revision was automatically updated to reflect the committed changes. Closed by commit rG636c67275142: [clang-tidy] Move formatDereference to FixitHintUtils (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL added a comment. I will push this change, no point to keep it open. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 ___ cfe-commits mailing list cfe-co

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe updated this revision to Diff 530384. mikecrowe added a comment. Rebase, no changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 Files: clang-tools-extra/clang-tidy/readability/RedundantSt

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe updated this revision to Diff 524815. mikecrowe added a comment. Make needParensAfterUnaryOperator static Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 Files: clang-tools-extra/clang-tidy/re

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe marked an inline comment as done. mikecrowe added a comment. Thanks for the review. New version with the `static` added coming shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 __

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, code compiles locally, restarted CI job (maybe will pass). Add [NFC] to change title before committing as this changes does not impact functionality. Comment at: c

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe created this revision. mikecrowe added reviewers: njames93, carlosgalvezp, PiotrZSL. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. I'd like