[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8de9f2b558a0: Move SubtargetFeature.h from MC to TargetParser (authored by jobnoorman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman updated this revision to Diff 534456. jobnoorman added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150549/new/ https://reviews.llvm.org/D150549 Files: clang/lib/CodeGen/BackendUti

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4380786 , @MaskRay wrote: > If we are certain this will not be reverted and cause churn, making the > header switch in one single patch looks fine to me... Great. I'm not sure if we can ever be a 100% certain it wi

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

MaskRay added a comment. In D150549#4352174 , @jobnoorman wrote: > In D150549#4351614 , @MaskRay wrote: > >> In D150549#4349531 , @jobnoorman >> wrote: >> >>> In D150549

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. Friendly ping. Any thoughts on my previous comment @MaskRay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150549/new/ https://reviews.llvm.org/D150549 ___ cfe-commits mailing

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4351614 , @MaskRay wrote: > In D150549#4349531 , @jobnoorman > wrote: > >> In D150549#4347056 , @MaskRay >> wrote: >> >>> This see

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

MaskRay accepted this revision. MaskRay added a comment. In D150549#4349531 , @jobnoorman wrote: > In D150549#4347056 , @MaskRay wrote: > >> This seems fine, but please consider making `MC/SubtargetFeature.h` a

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4347056 , @MaskRay wrote: > This seems fine, but please consider making `MC/SubtargetFeature.h` a > forwarding header temporarily. To be clear: do you want me to check-in this forwarding header or should I just do

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

MaskRay added a comment. This seems fine, but please consider making `MC/SubtargetFeature.h` a forwarding header temporarily. Our official build system CMake doesn't do layering checking for headers (https://llvm.org/docs/CodingStandards.html#library-layering). Our unofficial build system Baze

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

lhames added a comment. FWIW I'm in favor of this: as @jobnoorman mentioned it'd eliminate JITLink's library dependence on MC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150549/new/ https://reviews.llvm.org/D150549

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman created this revision. jobnoorman added reviewers: chandlerc, grosbach, andreadb, MaskRay, craig.topper. Herald added subscribers: bviyer, asb, luke, Moerafaat, zero9178, bzcheeseman, pmatos, sdasgup3, wenzhicui, wrengr, ormris, foad, cota, teijeong, frasercrmck, rdzhabarov, tatianash