[PATCH] D150452: [clang-format] Recognize nested blocks

2023-05-12 Thread sstwcw via Phabricator via cfe-commits
sstwcw abandoned this revision. sstwcw added a comment. I like D150403 better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150452/new/ https://reviews.llvm.org/D150452 __

[PATCH] D150452: [clang-format] Recognize nested blocks

2023-05-12 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. On this change I like the token annotator tests, and reusing the same stack instead of adding a second one which always has the same size. But the code changes in D150403 seem to be better, at least I couldn't think directly

[PATCH] D150452: [clang-format] Recognize nested blocks

2023-05-12 Thread Galen Elias via Phabricator via cfe-commits
galenelias added a comment. Coincidentally I also sent out a review to fix this issue yesterday, but went with a different approach of trying to scope the ProbablyBracedList logic by just looking at the lbrace previous token. https://reviews.llvm.org/D150403 Repository: rG LLVM Github Monor

[PATCH] D150452: [clang-format] Recognize nested blocks

2023-05-12 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 521667. sstwcw added a comment. - Remove the special case for operator[], it isn't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150452/new/ https://reviews.llvm.org/D150452 Files: clang/lib/Format

[PATCH] D150452: [clang-format] Recognize nested blocks

2023-05-12 Thread sstwcw via Phabricator via cfe-commits
sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Now a block gets recognized as a block if it contains a bloc