[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b240cc377b5: [tidy] Expose getID to tidy checks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150254/new/ https://reviews.llvm.org/

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet added a comment. In D150254#4331738 , @njames93 wrote: > In D150254#4331640 , @kadircet > wrote: > >> see >> https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidy.cpp#L63

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet updated this revision to Diff 520936. kadircet added a comment. - Expose getID to tidy-checks and use it instead of storing checkname Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150254/new/ https://reviews.llvm.org/D150254 Files: clan

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

njames93 added a comment. In D150254#4331734 , @hokein wrote: > The fix looks good. > > We also have a `CheckName` field in the base class `ClangTidyCheck`, however > that's field is private, we can't not access, we could consider make it > protected (I

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

njames93 added a comment. In D150254#4331640 , @kadircet wrote: > see > https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidy.cpp#L638 > for such a pattern, clangd also initializes checks with a similar approach. In this

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The fix looks good. We also have a `CheckName` field in the base class `ClangTidyCheck`, however that's field is private, we can't not access, we could consider make it protected (I think tha

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet added a comment. see https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/ClangTidy.cpp#L638 for such a pattern, clangd also initializes checks with a similar approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D150254: [tidy] Fix possible use-after-free in IdentifierNamingCheck

kadircet created this revision. kadircet added reviewers: hokein, PiotrZSL. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe