This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG78d8312acea9: [Clang][clang-cl] Implement
`__builtin_FUNCSIG` (authored by JMazurkiewicz, committed by aaron.ballman).
Repository:
rG LLVM Github
JMazurkiewicz added a comment.
> Do you need someone to commit on your behalf? If so, what name and email
> address would you like used for patch attribution?
Yes, my name and email: "Jakub Mazurkiewicz ".
> I can fix up the release notes when I land, so you don't have to upload a new
> patch.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM assuming precommit CI doesn't come back with surprises, though there are
some minor typos in the release notes to be fixed. Do you need someone to
commit on your behalf? If
JMazurkiewicz updated this revision to Diff 523360.
JMazurkiewicz marked 2 inline comments as done.
JMazurkiewicz added a comment.
- Address comments (thanks for the review @aaron.ballman!),
- Remove `clang-format` changes (CI might fail),
- Add extra tests in `clang/test/Preprocessor/feature_test
aaron.ballman added a comment.
Thank you! In general, this is looking pretty close to ready.
Comment at: clang/lib/Parse/ParseExpr.cpp:807-809
+/// [C++11] simple-type-specifier braced-init-list[C++11 5.2.3]
/// [C++] typename-specifier '(' expression-list[op
JMazurkiewicz updated this revision to Diff 523082.
JMazurkiewicz added a comment.
Try to fix formatting in `ParseExpr.cpp`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150183/new/
https://reviews.llvm.org/D150183
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.r
JMazurkiewicz created this revision.
JMazurkiewicz added a reviewer: clang.
Herald added a project: All.
JMazurkiewicz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch implements `__builtin_FUNCSIG` intrinsic which returns the sam
