[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added a comment. Build failures seem unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG535f34dd80c2: [index][clangd] Consider labels when indexing function bodies (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler updated this revision to Diff 545551. ckandeler added a comment. Addressed another review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: clang-tools-extra/clangd/unittests/XRe

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge added a comment. In D150124#4542032 , @kadircet wrote: > btw, thanks a lot Nathan for taking good care of clangd, I don't think I say > that enough I'm happy to help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:150 +ParentDC, +unsigned(SymbolRole::NameReference)); + } ckandeler wrote: > kadircet wrote: > > nridge wrote: > > > `

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:150 +ParentDC, +unsigned(SymbolRole::NameReference)); + } kadircet wrote: > nridge wrote: > > `NameReference` was i

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

kadircet added a comment. sorry for missing this review. Nathan's explanation around `targetDecl` vs `findRefs` is absolutely right (btw, thanks a lot Nathan for taking good care of clangd, I don't think I say that enough). hopefully one day we can switch clangd's usage of libindex to our inter

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler updated this revision to Diff 545054. ckandeler added a comment. Addressed review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: clang-tools-extra/clangd/unittests/XRefsTests.

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge added a comment. In D150124#4329163 , @ilya-biryukov wrote: > In `clangd` we also have `findExplicitReferences` and `targetDecl` functions > that seem to handle the `GoToStmt`. > In fact, I believe they are used in `findDocumentHighlights`, so I'

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler updated this revision to Diff 521577. ckandeler marked 2 inline comments as done. ckandeler added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: c

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added a comment. In D150124#4329163 , @ilya-biryukov wrote: > In `clangd` we also have `findExplicitReferences` and `targetDecl` functions > that seem to handle the `GoToStmt`. According to the commit message of the patch that added this, it

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ilya-biryukov added a reviewer: kadircet. ilya-biryukov added a comment. In `clangd` we also have `findExplicitReferences` and `targetDecl` functions that seem to handle the `GoToStmt`. In fact, I believe they are used in `findDocumentHighlights`, so I'm not sure why your test did not work befor

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ilya-biryukov added a comment. Thanks! This looks like a useful addition. Could you add a test into `libIndex` for this too? Just for the sake of having better coverage, some folks probably don't run `clang-tools-extra` tests. Also, could we add a test that a label does not get indexed if local

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler created this revision. ckandeler added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, clang-tools-extra. It's