This revision was automatically updated to reflect the committed changes.
mboehme marked an inline comment as done.
Closed by commit rG48bc71505e03: [clang][dataflow] Eliminate
`SkipPast::ReferenceThenPointer`. (authored by mboehme).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
mboehme marked an inline comment as done.
mboehme added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:840
+return nullptr;
+ } else {
+return cast(Loc);
ymandel wrote:
> nit: no need for `else` since `if` branch al
mboehme updated this revision to Diff 521607.
mboehme added a comment.
Eliminate unnecessary `else`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149838/new/
https://reviews.llvm.org/D149838
Files:
clang/include/clang/Analysis/FlowSensitive/Dat
ymandel accepted this revision.
ymandel added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:840
+return nullptr;
+ } else {
+return cast(Loc);
nit: no need for `else` since `if` branch always returns
Repository:
mboehme updated this revision to Diff 521269.
mboehme added a comment.
Rebase to head
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149838/new/
https://reviews.llvm.org/D149838
Files:
clang/include/clang/Analysis/FlowSensitive/DataflowEnvironmen
mboehme created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As a replacement, we provide the accessors `getI
