This revision was automatically updated to reflect the committed changes.
Closed by commit rGdd6a58babc85: [Sema] Avoid emitting warnings for constant
destruction. (authored by pkasting, committed by xgupta).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
pkasting added a comment.
Thanks @rsmith; I don't have commit access, so can you land the updated patch
for me?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149713/new/
https://reviews.llvm.org/D149713
___
pkasting updated this revision to Diff 519188.
pkasting added a comment.
Update test per review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149713/new/
https://reviews.llvm.org/D149713
Files:
clang/lib/Sema/SemaDeclCXX.cpp
clang/te
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with the extra test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149713/new/
https://reviews.llvm.org/D149713
___
rsmith added a comment.
I think this would be an interesting test:
struct S {
/*not constexpr*/ S();
constexpr ~S() {}
};
S s; // no warning
struct T {
/*not constexpr*/ T();
constexpr ~T() { if (b) {} }
bool b;
};
T t; // expected-warning {{exit-time destructor
pkasting created this revision.
pkasting added a reviewer: rsmith.
Herald added a project: All.
pkasting requested review of this revision.
Herald added a project: clang.
Fixes https://github.com/llvm/llvm-project/issues/62436.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D149
