[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1c0e3be6f09: [clang][Interp] Fix compound assign operator evaluation order (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149550/new/

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with an extra comment added. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + //

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149550/new/ https://reviews.llvm.org/D149550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. ---

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. tbaeder wrote:

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. aaron.ballman wrote:

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. tbaeder wrote:

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder updated this revision to Diff 519428. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149550/new/ https://reviews.llvm.org/D149550 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/floats.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder updated this revision to Diff 519370. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149550/new/ https://reviews.llvm.org/D149550 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/floats.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. tbaeder wrote: > aar

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. aaron.ballman wrote:

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:683-685 + // C++17 onwards require that we evaluate the RHS first. + // Compute RHS and save it in a temporary variable so we can + // load it again later. In C, the eval

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to evaluated the RHS before the LHS. Re