[PATCH] D149518: [clang] Optimize clang::ASTNodeKind::isBaseOf

2023-05-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oh wow, I'm surprised that calculating the distance has that much compile time impact. Great catch! Please add `NFC` to the commit summary so folks know why there are no tests.

[PATCH] D149518: [clang] Optimize clang::ASTNodeKind::isBaseOf

2023-04-29 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Lookup matrix gives best result (~-80%), bu it consume lot of memory due to big amount of enumerators (~950). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149518/new/ https://reviews.llvm.org/D149518 ___

[PATCH] D149518: [clang] Optimize clang::ASTNodeKind::isBaseOf

2023-04-29 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL created this revision. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. PiotrZSL requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Create dedicated isBaseOf met